-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Detect and handle leading double slash paths #13510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 02605c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e3771c7
to
02605c5
Compare
// If this isn't a usage for absolute URLs (currently only for redirects), | ||
// then we need to avoid the URL constructor treating a leading double slash | ||
// as a protocol-less URL. By prepending the base, it forces the double slash | ||
// to be parsed correctly as part of the pathname. | ||
if (!isAbsolute && href.startsWith("//")) { | ||
// new URL('//', 'https://localhost') -> error! | ||
// new URL('https://localhost//', 'https://localhost') -> no error! | ||
href = base + href; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the new behavior - which we don't want to apply to cases where we want to create an absolute URL, so we extract this utility for direct usage in the redirect case where we have an absolute URL.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Closes #11188
Closes #11429
Closes #11911